Exposed additional options (marginSize, moduleSize, & fnc1) from dmtxencode.c - #83
Open
james-duvall wants to merge 1 commit into
Open
Exposed additional options (marginSize, moduleSize, & fnc1) from dmtxencode.c#83james-duvall wants to merge 1 commit into
james-duvall wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for creating pylibdmtx and also for packaging the Windows libdmtx binaries in the Wheel.
I found that I needed to be able to specify the DmtxProperty.DmtxPropModuleSize and DmtxPropMarginSize parameters to encode an acceptable Data Matrix for MIL-STD-130N. These seem like very useful parameters that should be exposed by pylibdmtx.
For example, my label printer has a 180 dpi resolution and the default module size of 5 pixels makes the data matrix too big.
I created a fix that works for me, but I'd be happy to discuss and help with creating a revision that can be merged into the project.